Drozdov_Nikita by pepya4ka · Pull Request #38 · NikolaevArtem/Java_Core_June_2021

pepya4ka · 2021-07-11T08:05:57Z

No description provided.

src/main/java/homework_1/Main.java

NikolaevArtem · 2021-09-20T17:42:18Z

src/main/java/homework_4/custom_annotation/annotations/XmlConverter.java

+import java.util.Objects;
+import java.util.stream.Collectors;
+
+public class XmlConverter {


Nice idea and implementation!

NikolaevArtem · 2021-09-20T17:44:33Z

src/main/java/homework_4/custom_file_reader/Main.java

+public class Main {
+
+    public static void main(String[] args) {
+        new CustomFileReader().run1();


2nd case somehow broken:

Nice usage of abstractions!

NikolaevArtem · 2021-09-20T17:47:35Z

src/main/java/homework_5/custom_regex_matcher/Main.java

+public class Main {
+
+    public static void main(String[] args) {
+        new CustomRegexMatcher().run();


Good, real-life regex example with optional borders. Well-done!

NikolaevArtem · 2021-09-20T17:49:06Z

src/main/java/homework_5/power_of_number/Main.java

+public class Main {
+
+    public static void main(String[] args) {
+        new PowerOfNumber().run();


👍 Usage of BigInteger

NikolaevArtem · 2021-09-20T17:49:49Z

src/main/java/homework_5/power_of_number/PowerOfNumber.java

+    }
+
+    private BigInteger pow(BigInteger a, BigInteger b) {
+        if (b.compareTo(BigInteger.valueOf(0)) == 0) return BigInteger.valueOf(1);


Suggested change

if (b.compareTo(BigInteger.valueOf(0)) == 0) return BigInteger.valueOf(1);

if (b.compareTo(BigInteger.valueOf(0)) == 0) {

return BigInteger.valueOf(1);

}

Opt

Also, assigning new data to the same variables is usually a code smell

NikolaevArtem · 2021-09-20T17:54:12Z

src/main/java/homework_6/Main.java

+    private void runMapProblemsCollision() {
+    }


No examples for collision?

NikolaevArtem · 2021-09-20T17:57:26Z

src/main/java/homework_6/map_problems/MapProblemsMutableGenerator.java

+    @Override
+    public int hashCode() {
+        return new Random().nextInt(10);
+//        return new Random().nextInt();
+    }


The problem with mutable keys is that you can't find the value if you change the key. In your case, it's just hashcode doesn't follow contracts. Even with properly-written hashcode mutable objects as keys can be lost in case of changing (and rehashing as the result)

NikolaevArtem · 2021-09-20T17:59:31Z

src/main/java/homework_7/Main.java

+
+import static homework_7.model.Sex.*;
+
+public class Main {


:D nice, good examples!

NikolaevArtem · 2021-09-20T18:05:21Z

src/main/java/course_project/Game.java

+
+import static course_project.services.GameService.*;
+
+public class Game extends BaseClazz {


It's quite difficult to put ships manually, especially because the field does not refresh

I got it, you refresh after the type of ships was placed. Smart move

Some bug in field rendering

Also time between turns is quite long, could you please reduce sleep time?

NikolaevArtem

Quite good! Found some bugs in HW_6 and course project, please fix. In general looks nice, easy to understand, good usage of abstractions and Java Core, as well as Java libraries

NikolaevArtem · 2021-09-23T10:28:44Z

HW and Cource Project approved! Although you could do better on course project, it is working now and I didn't reproduce the last bug and didn't see any new. If you have time, please refactor and ping me. If not, it's fine as is

…warning of re-hit

Drozdov added 2 commits July 11, 2021 11:01

add homework_1

14ecb8d

refactor README.md

c36f3b8

NikolaevArtem reviewed Jul 11, 2021

View reviewed changes

src/main/java/homework_1/Main.java Outdated Show resolved Hide resolved

NikolaevArtem added the bug Code fix needed label Jul 11, 2021

NikolaevArtem changed the title ~~DrozdovNikita_homework~~ Drozdov_Nikita Jul 11, 2021

Drozdov added 2 commits July 11, 2021 23:55

update homework_1

caa0d07

del serr, add "\033[0;31m" in sout

0939a72

pepya4ka added readyForReview Sign for Artem to take a look bug Code fix needed and removed bug Code fix needed labels Jul 12, 2021

NikolaevArtem added HW_1 Good to go and removed bug Code fix needed readyForReview Sign for Artem to take a look labels Jul 13, 2021

pepya4ka added readyForReview Sign for Artem to take a look and removed readyForReview Sign for Artem to take a look labels Jul 15, 2021

Drozdov added 2 commits July 15, 2021 20:34

homework_2, 1st task done

5321ff5

homework_2, 2nd task done

b1fda1f

pepya4ka added the readyForReview Sign for Artem to take a look label Jul 15, 2021

Drozdov added 3 commits July 16, 2021 08:38

homework_2, 1st task refactor

95f480c

homework_2, 3rd task done

7ce3d3c

update README.md

f5158ab

AlexandrKirshin added readyForReview Sign for Artem to take a look and removed readyForReview Sign for Artem to take a look labels Jul 19, 2021

update README.md

342868e

NikolaevArtem removed the readyForReview Sign for Artem to take a look label Jul 20, 2021

Drozdov added 3 commits July 21, 2021 04:35

refactor TrafficLight

e39ae9a

refactor PyramidPrinter

9bfa59f

refactor RandomCharsTable

248fc44

pepya4ka added the readyForReview Sign for Artem to take a look label Jul 21, 2021

add ImmutableClass

a24124e

NikolaevArtem removed readyForReview Sign for Artem to take a look style Style fix needed readyForStudentReview labels Sep 20, 2021

NikolaevArtem reviewed Sep 20, 2021

View reviewed changes

NikolaevArtem added the HW_4 label Sep 20, 2021

NikolaevArtem reviewed Sep 20, 2021

View reviewed changes

NikolaevArtem added the HW_5 label Sep 20, 2021

NikolaevArtem reviewed Sep 20, 2021

View reviewed changes

src/main/java/homework_7/Main.java

import static homework_7.model.Sex.*;

public class Main {

Copy link

Owner

NikolaevArtem Sep 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D nice, good examples!

NikolaevArtem added the HW_7 label Sep 20, 2021

NikolaevArtem reviewed Sep 20, 2021

View reviewed changes

NikolaevArtem added the bug Code fix needed label Sep 20, 2021

NikolaevArtem suggested changes Sep 20, 2021

View reviewed changes

pepya4ka added 4 commits September 21, 2021 02:42

refactor hw6 MapProblemsGenerator

d17e937

refactor hw6 MapProblemsGenerator

d8ee91a

beta 2

f5fa480

refactor hw5 PowerOfNumber

07b95a7

pepya4ka added the readyForReview Sign for Artem to take a look label Sep 21, 2021

pepya4ka added 2 commits September 21, 2021 21:32

CP: add some message for players

203ef1d

update README.md

dd2df0e

NikolaevArtem added Course Project HW_6 and removed bug Code fix needed readyForReview Sign for Artem to take a look labels Sep 23, 2021

CP: add autoset marks around sunken ship, mark damage on your field, …

e34eceb

…warning of re-hit


		import static course_project.services.GameService.*;

		public class Game extends BaseClazz {

Conversation

pepya4ka commented Jul 11, 2021

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NikolaevArtem left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NikolaevArtem commented Sep 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

NikolaevArtem left a comment •

edited

Loading